Skip to content

Toggle File Name Fixes#1691

Open
NicAtMS wants to merge 1 commit into
ci_prodfrom
ToggleNameFixes
Open

Toggle File Name Fixes#1691
NicAtMS wants to merge 1 commit into
ci_prodfrom
ToggleNameFixes

Conversation

@NicAtMS
Copy link
Copy Markdown
Contributor

@NicAtMS NicAtMS commented May 18, 2026

No description provided.

@NicAtMS NicAtMS requested a review from a team as a code owner May 18, 2026 16:43
@NicAtMS NicAtMS enabled auto-merge (squash) May 18, 2026 17:02
rashmichandrashekar
rashmichandrashekar reviewed May 18, 2026
View reviewed changes
Comment thread toggles/OmsAgent.DsCpuLimitLinux.json
@@ -1,520 +0,0 @@
{
"Version": "1",
"ToggleName": "OmsAgent.DsCpuLimitLinux",
Copy link
Copy Markdown
Contributor

@rashmichandrashekar rashmichandrashekar May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NicAtMS - why are the deleted files not moved to their equivalent correct ones?

Copy link
Copy Markdown
Contributor

@rashmichandrashekar rashmichandrashekar May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here are the values -

Docker-Provider/charts/azuremonitor-containerinsights/values.yaml

Lines 54 to 63 in 1b2d31b

# Resource limits and requests
omsAgentDsCPULimitLinux: "500m"
omsAgentDsMemoryLimitLinux: "1Gi"
omsAgentDsCPULimitWindows: "2"
omsAgentDsMemoryLimitWindows: "2Gi"
omsAgentDsCPURequestWindows: "100m"
omsAgentDsMemoryRequestWindows: "150Mi"
omsAgentRsCPULimit: "1"
omsAgentRsMemoryLimit: "1.5Gi"
omsAgentPrometheusSidecarCPULimit: "500m"

Copy link
Copy Markdown
Contributor Author

@NicAtMS NicAtMS May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rashmichandrashekar We already have these files stored properly: https://github.com/microsoft/Docker-Provider/blob/1ae6f44ba6feb6f7eed2ef639dcac8e1ee27ec62/toggles/OmsAgent.omsAgentDsCPULimitLinux.json. These were artifacts left over from previously incorrect toggle names

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rashmichandrashekar rashmichandrashekar rashmichandrashekar left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

no-pr-activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NicAtMS @rashmichandrashekar